Update dockerd.md#3173
Conversation
daemon.json does not exist on a clean install. The doc should reflect that. Signed-off-by: René Hermenau <rene-hermenau@users.noreply.github.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
did a rebase and minor touch-up
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks @thaJeztah I totally forgot this 5 year old PR🤣 |
|
Heh, yeah, definitely the same; I was spending a bit of time going through old PRs. Not sure why this wasn't merged at the time, but .. not unlikely I looked at it from my phone and wanted to check it from my computer later and then forgot. |
|
#6997 should fix the failing milestone check |
|
@vvoland yeah, didn't want to do a rebase just for that, so we can probably just ignore it? but I can't review this PR because I did the last rebase 😅 |
|
Oh! Sorry, thought You linked to the "VERSION" bump PR; nevermind 🙈 |
|
We can't merge because the check is required 😅 |
|
I don't think it's required; 
I think it's blocking because my review no longer counts; 
|
|
Oh right! |
5 participants
daemon.json does not exist on a clean install. The doc should reflect that.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)